You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
workspace: allow unused_workspace_dependencies in the Cargo lint table - #1269
unused_workspace_dependencies is a Cargo lint, but the root Cargo.toml set it under [workspace.lints.rust] and [workspace.lints.clippy]. Cargo passed those entries to rustc and Clippy as -A unused_workspace_dependencies and -A clippy::unused_workspace_dependencies, and every crate reported warning[E0602]: unknown lint. The [lints] entry in .cargo/config.toml did not set the level either: Cargo 1.100 still printed 73 "unused workspace dependency" warnings.
Cargo 1.95 (the workspace rust-version) accepts the table but prints unused manifest key lints.cargo once per manifest, since [lints.cargo] was stabilized in Cargo 1.100 (https://doc.rust-lang.org/cargo/reference/unstable.html#lintscargo). The MSRV job runs cargo check without -D warnings, so it still passes.
Testing
Base: b77af389, which is current main; the branch merges into it cleanly.
cargo check --workspace --tests --locked (Cargo 1.100.0), before: 73 unused workspace dependency warnings, and 397 compiled targets (lib, test and build-script units) each reported the E0602 warning. After: none of either; the other warnings are unchanged.
No test is added: the change is manifest configuration, and the check output above shows its effect.
The Workspace workflow's clippy and test runs, on Linux, Windows and macOS, run in this pull request's CI.
Summary by CodeRabbit
Chores
Updated workspace lint configuration and removed a redundant Cargo configuration file. These changes affect project checks and configuration only; no changes to the application’s user-facing features or behavior.
unused_workspace_dependencies is a Cargo lint, so its level belongs in
[workspace.lints.cargo]. Under [workspace.lints.rust] and
[workspace.lints.clippy], Cargo passed it to rustc and Clippy as
-A unused_workspace_dependencies and -A clippy::unused_workspace_dependencies,
which each crate reported as E0602 (unknown lint). The [lints] entry in
.cargo/config.toml did not set the level either, so Cargo 1.100 still
printed 73 "unused workspace dependency" warnings for the workspace.
The allow now sits in [workspace.lints.cargo], which every member
inherits through [lints] workspace = true, and .cargo/config.toml is
removed. On Cargo 1.100, cargo check --workspace --tests prints no E0602
and no unused workspace dependency warnings. Cargo 1.95 accepts the table
but reports lints.cargo as an unused manifest key.
https://doc.rust-lang.org/cargo/reference/lints.html#unused_workspace_dependencieshttps://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table
No actionable comments were generated in the recent review.
Walkthrough
The unused workspace dependencies lint allowance moves from .cargo/config.toml to the [workspace.lints.cargo] section in Cargo.toml. The Rust and Clippy lint sections remain.
This change only adjusts lint configuration and does not affect runtime behavior. Older Cargo versions may print warnings about an unused manifest key, but builds should not fail.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: moving unused_workspace_dependencies to the Cargo lint table (workspace.lints.cargo). The raw summary confirms the Cargo.toml change moves that setting from workspace.…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: moving unused_workspace_dependencies to the Cargo lint table (workspace.lints.cargo). The raw summary confirms the Cargo.toml change moves that setting from workspace.lints.clippy to workspace.lints.cargo, and the PR objectives confirm removal of .cargo/config.toml. The title omits the config file removal, which is an acceptable omission. The title is specific and matches the changeset.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between b77af38 and 5f6984a.
Files selected for processing: 2
.cargo/config.toml
Cargo.toml
Files with no reviewable changes: 1
.cargo/config.toml
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unused_workspace_dependenciesis a Cargo lint, but the rootCargo.tomlset it under[workspace.lints.rust]and[workspace.lints.clippy]. Cargo passed those entries to rustc and Clippy as-A unused_workspace_dependenciesand-A clippy::unused_workspace_dependencies, and every crate reportedwarning[E0602]: unknown lint. The[lints]entry in.cargo/config.tomldid not set the level either: Cargo 1.100 still printed 73 "unused workspace dependency" warnings.This moves the allow into a new
[workspace.lints.cargo]table and removes it from the rust and clippy tables. Cargo's lint reference says "Cargo lints can be configured in the [lints.cargo] table of the Cargo.toml manifest" (https://doc.rust-lang.org/cargo/reference/lints.html#unused_workspace_dependencies), and members inheritworkspace.lintsthrough[lints] workspace = true(https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table). All 133crates/*/Cargo.tomlfiles keep[lints] workspace = true..cargo/config.toml, which held only that[lints]entry, is removed.Cargo 1.95 (the workspace
rust-version) accepts the table but prints unused manifest keylints.cargoonce per manifest, since[lints.cargo]was stabilized in Cargo 1.100 (https://doc.rust-lang.org/cargo/reference/unstable.html#lintscargo). The MSRV job runscargo checkwithout-D warnings, so it still passes.Testing
Base:
b77af389, which is currentmain; the branch merges into it cleanly.cargo check --workspace --tests --locked(Cargo 1.100.0), before: 73 unused workspace dependency warnings, and 397 compiled targets (lib, test and build-script units) each reported the E0602 warning. After: none of either; the other warnings are unchanged.cargo clippy --workspace --all-targets --locked -- -D warnings(1.100.0): passes, no E0602.cargo check --workspace --lib --all-features --locked(1.95.0): passes, no E0602, 135 unused manifest keylints.cargowarnings.cargo fmt --all -- --check: passes.Summary by CodeRabbit